Fix out-of-date (wrt XSD) HTML pages#216
Merged
Merged
Conversation
thbar
changed the title
…rictions The addition of `<xsd:minInclusive value="PT0S"/>` on PositiveDurationType (PR #188) introduced a duration value in XSD restrictions that xcore's castToComparable function did not handle. This caused max()/min() to fail with [FORG0006] on BaseX 10.6 (used in CI), as xs:duration is not an ordered type per the XQuery spec (I think). BaseX 12.1+ silently accepts it though (my local runs passed). Cast to xs:dayTimeDuration / xs:yearMonthDuration instead, which are the ordered subtypes that support comparison on all BaseX versions. See #218
thbar
changed the title
thbar
commented
May 17, 2026
thbar
commented
May 17, 2026
Collaborator
|
can you check my comment for ci.yml? otherwise approved |
thbar
commented
Jun 18, 2026
Collaborator
Author
@haeckerbaer done! I would love if you can double-check that part (see my comment) |
Collaborator
Author
|
@haeckerbaer bump! If you have time, I've added explanation etc. |
TuThoThai
approved these changes
Jun 22, 2026
haeckerbaer
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted while reviewing #196 (cardinality in the XSD versus HTML mode was not the same afaik), I finally understood that the workflow supposed to automatically update that has been disabled since the rename of the branches to
v2.0etc.The deploy to GitHub pages (if it was working before) is affected as well, to be discussed.
Note on pattern choice: the expressivity of the patterns is not very rich & precise (not full regex if I understand well), so I just choose a "good enough" pattern with what was supported, able to catch things like
v2.10-wipin the future.Things tracked while attempting to fix this
Note to reviewers
While I apparently managed to reactivate tables generation, the diff will need some review.